Incorporate NASA-SPIRE data using SATID

GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation

Apache License 2.0

1 stars 3 forks source link

Incorporate NASA-SPIRE data using SATID #155

Closed mohar123 closed 1 week ago

mohar123 commented 9 months ago

Changed the prepbykx.f90 to extract observations based on satid value. This change is made to extract NASA-SPIRE from the prepbufr files based on their SATIDs rather than their KX values.

github-actions[bot] commented 9 months ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

gmao-msienkie commented 9 months ago

As I have mentioned before, I am not in favor of modifying/using 'prepbykx.f' for processing anything but PREPBUFR format data. I feel like other data formats should have a separate program, mainly because most of the BUFR mnemonics it is trying to read are not present in other files. If there is a separate program for extracting data by SATID it could be enhanced to also include subsetting by latitude/longitude (CLATH/CLONH not YOB/XOB) or possibly other mnemonics that are unique to the GNSSRO.

rtodling commented 9 months ago

Mohar, I am gong to agree w/ Meta on this ... perhaps you can simply rename this program into a new name - and revive the original prepbufr program ....

mohar123 commented 9 months ago

I am going to rename the code and commit it but I would need help to trace my way back from the git push that I did from my working directory. If I change the name of the code to a brand new addition, I would require changing the Makefile as well, right?