search

GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation
Apache License 2.0
1 stars 3 forks source link

Proposed R21C changes 2024-01-29 #156

Closed sdrabenh closed 7 months ago

sdrabenh commented 8 months ago

Labeled as zero-diff from the GCM perspective. Updates originally from @elakkraoui

rtodling commented 8 months ago

Can you provide a written list of all changes made here, please? Amal is probably the person to do this. Thanks

elakkraoui commented 8 months ago

Can you provide a written list of all changes made here, please? Amal is probably the person to do this. Thanks

Here's a list of all the changes: List_updates_4_M21C_CandidateTag.docx

Let me know if you questions about any of theses. Thanks.

rtodling commented 7 months ago

Can you provide here the version number of GEOSana_GridComp this started from?

elakkraoui commented 7 months ago

Can you provide here the version number of GEOSana_GridComp this started from?

I started from v1.5.5

GEOSana_GridComp | (t) v1.5.5 (DH) | (b) feature/aelakkra/r21c_DAScandidate

rtodling commented 7 months ago

Amal and Scott - it seems to me this is still in Draft mode - I can't finish this until the PR is officially submitted

elakkraoui commented 7 months ago

Amal and Scott - it seems to me this is still in Draft mode - I can't finish this until the PR is officially submitted

You are right. They should've been submitted as official PRs. I'll check with Scott immediately.

sdrabenh commented 7 months ago

@rtodling @elakkraoui these PR were initially marked as drafts for reviewing. Clicking the button "Ready for review" now so they are regular PRs. Please keep in mind CircleCI may fail for some of these PRs as we don't have an automated way to checkout latest within the R21C branches just yet.