search

GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation
Apache License 2.0
1 stars 3 forks source link

Save SST for JEDI's tlap bias correction. #32

Closed gmao-jjin3 closed 3 years ago

gmao-jjin3 commented 3 years ago

JEDI's bias correction procedure needs "average_surface_temperature_within_field_of_view" in obs GeoVaLs for TLapse bias correction. This variable "tsavg5" was set missing in some GEOS diagnostic NC4 outputs in setuprad.f90. In this PR, this "tsavg5" is saved in all GSI's radiance data diagnostic NC4 files.

gmao-jjin3 commented 3 years ago

@mathomp4 What is "dimagi/required-labels " which fails a check? Thanks.

mathomp4 commented 3 years ago

@mathomp4 What is "dimagi/required-labels " which fails a check? Thanks.

@gmao-jjin3 We require you to add a label, say "0-diff" or "non-0-diff", so that the PR approver knows if this would change the results or not.

gmao-jjin3 commented 3 years ago

@mathomp4 Done. Thanks.

rtodling commented 3 years ago

JJ: Your change is out of sync w/ the branch ... but I don't have a problem w/ the change.

gmao-jjin3 commented 3 years ago

@rtodling Could you re-run x0044 for two cycles? I'd like to see whether we can make bias correction work in JEDI. Thank you very much!

rtodling commented 3 years ago

I am closing this since this is already in develop.