search

GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation
Apache License 2.0
1 stars 3 forks source link

Changes needed for IASI Metop-C in 5.29.0? #37

Closed mathomp4 closed 3 years ago

mathomp4 commented 3 years ago

Per a comment by @gmao-msienkie in #36 :

I just noticed that I hadn't put the entries for iasi_metop-c in the gsi.rc.tmpl and associated files. Fixed in my branch. modified: gsi.rc.tmpl modified: gsi_fdda_1.rc.tmpl modified: gsi_fdda_2.rc.tmpl modified: gsi_fgat_1.rc.tmpl modified: gsi_fgat_2.rc.tmpl modified: gsi_sens.rc.tmpl

these changes will also need to be made in this branch.

This issue is to track how to fix this. @gmao-msienkie is there a branch on this repo with the right changes?

And I guess, are they changes @rtodling knows of and agrees with, so they can go into develop and then main for a release.

mathomp4 commented 3 years ago

Staring at the branches here, perhaps feature/msienkie/CrIS-FSR_updates_satinfo is the right one? It seems to have roughly those edits...roughly.

mathomp4 commented 3 years ago

If I do a comparison, the changes from @gmao-msienkie branch are:

https://github.com/GEOS-ESM/GEOSana_GridComp/compare/develop...feature/msienkie/CrIS-FSR_updates_satinfo

I guess it's up to @rtodling if this should go into v5.29.0