search

GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation
Apache License 2.0
1 stars 3 forks source link

Fix for Intel Compiler Issue #47

Closed mathomp4 closed 3 years ago

mathomp4 commented 3 years ago

This PR fixes a weird bug seen when the GEOSadas is advanced to the latest sub-components (see https://github.com/GEOS-ESM/GEOSadas/pull/103).

For reasons yet unknown, when the sub-components are advanced, geos_StateIO.F90 fails with errors like:

/discover/swdev/mathomp4/Models/GEOSadas-5_29_0-with-Bills/GEOSadas/src/Components/@GEOSana_GridComp/GEOSaana_GridComp/GEOSgsi_Coupler/geos_StateIO.F90(1442): error #6404: This name does not
 have a type, and must have an explicit type.   [SG]
      do j=1,sg%lon2
-------------^

Note: This seems to happen with both Intel 19.1.3 and Intel 2021.2. It is unknown if GNU would show an issue as the GNU compilers cannot as yet compile the GEOSadas.

The fix in this PR (by @rtodling) is to make some internal procedures external.

rtodling commented 3 years ago

The fix for this is now under:

feature/rtodling/change_due2odd_compiler_bug

mathomp4 commented 3 years ago

Closed in favor of #48