search

GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation
Apache License 2.0
1 stars 3 forks source link

updates for FSOI in NCDIAG #6

Closed will-mccarty closed 4 years ago

will-mccarty commented 5 years ago

These updates are to enable the writing of the FSOI variables to the ncdiag format instead/in addition to within the binary files.

The results were compared between the log file in the GSI log file and the NCDiag files, and they match exactly.

gmao-msienkie commented 5 years ago

There is a problem with genstats_gps.f90. The code added to write out the FSOI variables to the nc4 file modifies the variable 'ioff', before it is written to the header of the binary diag file. Thus the wrong value is written to the header which will cause trouble for the ODS conversion of the binary file.

gmao-msienkie commented 5 years ago

Also, the code in setupoz.f90 to write the FSOI variables for the layer ozone observations was left commented out.

gmao-msienkie commented 5 years ago

I pushed my branch 'feature/msienkie/NCDiag_Updates' which includes your changes as well as fixes for setupoz.f90 and genstats_gps.f90. I also have a version of 'read_diags.f90' that changes the radiance variables in the nc4 section to r_single to match the current 'setuprad' output, and will skip reading the 'tpwc_amsua' variable if it is not available in the nc4 file.

mathomp4 commented 4 years ago

@will-mccarty This probably will need to be redone with the new GEOSadas-5_27_1 candidate that is coming soon. Apologies