search

GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation
Apache License 2.0
1 stars 3 forks source link

Changes made in GSI to assimilate all-sky ATMS #64

Closed mjkagnes123 closed 2 years ago

mjkagnes123 commented 2 years ago

Changes to assimilate all-sky ATMS water vapor channels. The changes were made on top of x0045a.

jing-guo commented 2 years ago

GitHub is asking to "merge the latest changes from develop into this branch". Although I tried it without any problem, it seems gitHub is expecting it to be done from you.

Also, it might be helpful for information tracking if you can include some very brief descriptions for each intended subjects included in this change set, as while as justifications of inclusion in the coming release.

gmao-msienkie commented 2 years ago

There is a requirement to add a label (see on upper right hand side of the page) to a PR for it to be accepted. Judging from the content I added 'enhancement' - this can be changed if it is not appropriate.

jing-guo commented 2 years ago

Thanks Meta for fixing the status label!

For now, I am still not able to get over with "all checks have failed" flag.

I am sending the issue to Matt for advice.

mathomp4 commented 2 years ago

Thanks Meta for fixing the status label!

For now, I am still not able to get over with "all checks have failed" flag.

I am sending the issue to Matt for advice.

@jing-guo The issue is that the "required" labels are:

We require one of those so that gatekeepers know if a PR should change the "answer" of the model/code or not. So, I suppose this is non-zero-diff? Not sure how to label it.

jing-guo commented 2 years ago

After updated to the current develop HEAD, this change contains only a feature enhancement to proper processing of ATMS observation. And it should be zero-diff, if ATMS is not in use. Based on this, I do want to set the required label to zero-diff with enhancement.

However, this change (after synched to the current develop HEAD) does contain differences in their ATMS channel info configuration data. With this consideration, it is also labeled with observation-configuration, to catch integrators' attention.

rtodling commented 2 years ago

Jing - as it turned out this code was not at all zero-diff. The fact that this was put on develop messed me up big time. Please next time let's review only the ticket in question. Thanks.