GEOS-ESM / GEOSana_GridComp

Repository containing code for data analysis for the GEOS Earth System Model data assimilation
Apache License 2.0
1 stars 3 forks source link

Edits for creating UFO test files and AMV updates in x0045. #93

Closed gmao-jjin3 closed 1 year ago

gmao-jjin3 commented 2 years ago

Update CRTM coefs path in "analyzer" (04/2022) Major updates in setuprad.f90 and crtm_interface.f90

Added "half_goesr_err" in gsimod.F90, and qcmod.f90 which was updated in x0045, which is not necessary for producing UFO testing files (03/2022).

gmao-jjin3 commented 2 years ago

I see there are conflicts. Since these updates aim to reproduce x0044 results at the moment, I tends not resolve these conflicts until we want to use them in a new experiment.

gmao-jjin3 commented 2 years ago

GPS data can be converted to IODA files after these updates are added in GSI. However, stationary data in "conv_pwnc4" and "TCP" data in "conv_tcp" cannot be converted. Reasons are unknown at moment.

rtodling commented 2 years ago

I don't understand why any of these changes are non-zero diff to what we presently have in 5.29.4 - I suggest working on these changes to make sure they are zero-diff to the what was used to x0046a; I can only approve when this is the case. Also, I don't understand why you are changing the knob I put in setupw - half_goes_err - that was put in to avoid messing up w/ whatever NCEP had done. It needs to be in.

gmao-jjin3 commented 1 year ago

These updates were merged into a new branch bugfix/rtodling/jjin_netcdf4_ufo and eventually into the develop branch by @rtodling . Therefore this PR is closed.