Add mepo and CircleCI - Githubissues

GEOS-ESM / GEOSctm

Fixture for chemical transport scenarios

Apache License 2.0

0 stars 2 forks source link

Add mepo and CircleCI #23

Closed mathomp4 closed 4 years ago

mathomp4 commented 4 years ago

Add components.yaml
Update parallel_build.csh for support using mepo
- Note: Still defaults to checkout_externals though that will change soon
Remove odd blank .gitmodules file. We don't have submodules...
Updates to various .gitignore files
Add CircleCI config

mmanyin commented 4 years ago

@mathomp4 Sorry I lost track of this PR. Did we intentionally put it on hold?

mathomp4 commented 4 years ago

@mathomp4 Sorry I lost track of this PR. Did we intentionally put it on hold?

I don't think so. You can approve or not at your leisure. All the updates are beneficial. Though if there have been updates to the CTM in the mean time (different versions of sub repositories) then the components.yaml should be updated

mmanyin commented 4 years ago

@mathomp4 Looks good. I suppose that for the sake of consistency, mepo should clone exactly the same repo tags as checkout_externals. I notice that ecbuild is different. Would you mind making mepo use the old tag for ecbuild, and in the near future I will update all the repo's to mirror the tags in GCM ? NOTE: old tag is origin/feature/FindMKL-portability-improvement, where you set something to "prevent loud warning", but the new tag is geos/v1.0.0 which does not mention this. I trust that the loud warning is no longer an issue.

mathomp4 commented 4 years ago

@mathomp4 Looks good. I suppose that for the sake of consistency, mepo should clone exactly the same repo tags as checkout_externals. I notice that ecbuild is different. Would you mind making mepo use the old tag for ecbuild, and in the near future I will update all the repo's to mirror the tags in GCM ? NOTE: old tag is origin/feature/FindMKL-portability-improvement, where you set something to "prevent loud warning", but the new tag is geos/v1.0.0 which does not mention this. I trust that the loud warning is no longer an issue.

@mmanyin Well, they are essentially the same. geos/v1.0.0 was a stable tag of the feature/FindMKL-portability-improvementbranch. There is now a geos/v1.0.1 that has an fix/workaround for an ugly warning CMake 3.17 puts out with ecbuild. I moved the GCM away from every branch I could in Externals.cfg and in mepo because branches can move, tags can't (shouldn't).

But if you want the branch, I can do that.

mmanyin commented 4 years ago

@mathomp4 Would the change in ecbuild possibly make this non-zero-diff ?

mathomp4 commented 4 years ago

Nope. The difference is changing the word OLD to NEW for a CMake policy that should only affect someone running on macOS. It didn’t for me on my laptop, but if it does for you please let me or @tclune know

mmanyin commented 4 years ago

@mathomp4 Thanks! I agree on the fact that branches don't belong in releases, or even in master. I will remedy that soon!