search

GEOS-ESM / GEOSctm

Fixture for chemical transport scenarios
Apache License 2.0
0 stars 2 forks source link

CTM will not build with GEOSchem_GridComp set to develop branch #28

Closed WilliamJamieson closed 4 years ago

WilliamJamieson commented 4 years ago

The CTM will not build when GEOSchem_GridComp is checked out to the master branch.

One gets error messages of the following form:

/discover/swdev/wjamieso/GEOS/CTM_HEMCO/GEOSctm/src/Components/GEOSctm_GridComp/CTMconvection_GridComp/GenericConvectionMethod_mod.F90(144): error #6632: Keyword arguments are invalid without an explicit interface.   [DEFAULT]
     &               "det_ent:", default=.false., rc=STATUS )
---------------------------------^
/discover/swdev/wjamieso/GEOS/CTM_HEMCO/GEOSctm/src/Components/GEOSctm_GridComp/CTMconvection_GridComp/GenericConvectionMethod_mod.F90(144): error #6632: Keyword arguments are invalid without an explicit interface.   [RC]
     &               "det_ent:", default=.false., rc=STATUS )
--------------------------------------------------^
/discover/swdev/wjamieso/GEOS/CTM_HEMCO/GEOSctm/src/Components/GEOSctm_GridComp/CTMconvection_GridComp/GenericConvectionMethod_mod.F90(148): error #6632: Keyword arguments are invalid without an explicit interface.   [DEFAULT]
     &               "do_downdraft:", default=.false., rc=STATUS )
--------------------------------------^
/discover/swdev/wjamieso/GEOS/CTM_HEMCO/GEOSctm/src/Components/GEOSctm_GridComp/CTMconvection_GridComp/GenericConvectionMethod_mod.F90(148): error #6632: Keyword arguments are invalid without an explicit interface.   [RC]
     &               "do_downdraft:", default=.false., rc=STATUS )
-------------------------------------------------------^
compilation aborted for /discover/swdev/wjamieso/GEOS/CTM_HEMCO/GEOSctm/src/Components/GEOSctm_GridComp/CTMconvection_GridComp/GenericConvectionMethod_mod.F90 (code 1)
src/Components/GEOSctm_GridComp/CTMconvection_GridComp/CMakeFiles/CTMconvection_GridComp.dir/build.make:92: recipe for target 'src/Components/GEOSctm_GridComp/CTMconvection_GridComp/CMakeFiles/CTMconvection_GridComp.dir/GenericConvectionMethod_mod.F90.o' failed
make[2]: *** [src/Components/GEOSctm_GridComp/CTMconvection_GridComp/CMakeFiles/CTMconvection_GridComp.dir/GenericConvectionMethod_mod.F90.o] Error 1
CMakeFiles/Makefile2:9148: recipe for target 'src/Components/GEOSctm_GridComp/CTMconvection_GridComp/CMakeFiles/CTMconvection_GridComp.dir/all' failed
make[1]: *** [src/Components/GEOSctm_GridComp/CTMconvection_GridComp/CMakeFiles/CTMconvection_GridComp.dir/all] Error 2
Makefile:179: recipe for target 'all' failed
make: *** [all] Error 2

This is likely related to the following cleanup commit: https://github.com/GEOS-ESM/GEOSchem_GridComp/commit/dbcc7fbf2e48fdf4fda4349681234e9af58cad8e#diff-b8425f43f47b5b8b76d182087d4e9d50

It is likely fixed by changing form rcEsmfReadLogical to ESMF_ConfigGetAttribute.

mmanyin commented 4 years ago

@WilliamJamieson You are correct. We have not yet updated CTM to be compatible with the latest version of GEOSchem_GridComp. When that is complete (and tested), a new CTM release will be issued. Is this time-critical for you?

WilliamJamieson commented 4 years ago

@mmanyin This is not time-critical. I just noticed this issue when I began work to start refactoring part of the GEOSchem_GridComp as a part of a proof of concept that we can start using HEMCO pulled from the new HEMCO repository: https://github.com/GEOS-ESM/HEMCO, instead of using what was copied directly into GEOSchem_GridComp from Harvard.

mmanyin commented 4 years ago

@WilliamJamieson Sounds good. Since I am tracking CHEM changes in both the CVS (Icarus) and GIT (Jason) versions, for both GCM and CTM, there are times when one gets ahead of the others. Thanks for understanding.

WilliamJamieson commented 4 years ago

@mmanyin I went ahead and submitted a PR to resolve this, its a zero-diff minor change and it works with the current configuration and with GEOSchem_GridComp develop as well.