GEOS-ESM / GEOSctm

Fixture for chemical transport scenarios
Apache License 2.0
0 stars 2 forks source link

Update CTM to be in line with GEOSgcm 10.19.5 #41

Closed mathomp4 closed 2 weeks ago

mathomp4 commented 2 years ago

Since #39 was just merged, I figured it's time to get in line with 10.19.5. This should be zero-diff, but I'll let @mmanyin test.

Mainly components and scripting, but there is one bit that might look interesting. I removed all the CVS bits from ctm_setup since, well, they were useless in Git land and added the new bits for the source tarfile. For more information see:

https://github.com/GEOS-ESM/GEOSgcm/issues/342

There is a chunk of text added to the README.md about this:

Create and install source tarfile

Note that running with parallel_build.csh will create and install a tarfile of the source code at build time. But if CMake is run by hand, this is not the default action (as many who build with CMake by hand are developers and not often running experiments). In order to enable this at install time, add:

-DINSTALL_SOURCE_TARFILE=ON

to your CMake command.

mmanyin commented 2 years ago

@mathomp4 is there a way to turn OFF the tarfile generation, when running parallel build?

mathomp4 commented 2 years ago

@mathomp4 is there a way to turn OFF the tarfile generation, when running parallel build?

Oh. Hmm. Maybe not. I guess I realized a lot of the people that run parallel_build.csh (for the GCM) were often the same people who wanted something like a tarfile of the source code they built. And since parallel_build.csh is more of a "hands-off" build process, most of those users wouldn't be affected by the extra minute or two for the tar'ing.

But it wouldn't be too hard to add an option to parallel_build.csh that turns that "ON" into a "OFF". Give me a hour or so to code something up a la parallel_build.csh -notar or something similar.

Or, if you like, I could just remove any reference to the source-tarfile CMake code with the CTM.

mathomp4 commented 2 years ago

@mathomp4 is there a way to turn OFF the tarfile generation, when running parallel build?

Oh. Hmm. Maybe not. I guess I realized a lot of the people that run parallel_build.csh (for the GCM) were often the same people who wanted something like a tarfile of the source code they built. And since parallel_build.csh is more of a "hands-off" build process, most of those users wouldn't be affected by the extra minute or two for the tar'ing.

But it wouldn't be too hard to add an option to parallel_build.csh that turns that "ON" into a "OFF". Give me a hour or so to code something up a la parallel_build.csh -notar or something similar.

Or, if you like, I could just remove any reference to the source-tarfile CMake code with the CTM.

Okay. I'm testing a -notar option now. I'll let you know how it goes (annoyingly I have to build the whole model to test! Fun with CMake! 😄 )

mmanyin commented 2 years ago

@mathomp4 The -notar option would be much appreciated, thanks!

mathomp4 commented 2 years ago

@mathomp4 The -notar option would be much appreciated, thanks!

Done. I called it -no-tar in the end. Read better to me.

mathomp4 commented 2 weeks ago

Wildly out of date. I can redo if needed.