search

GEOS-ESM / GEOSctm

Fixture for chemical transport scenarios
Apache License 2.0
0 stars 2 forks source link

Update MERRA2 Replay Location #47

Closed mathomp4 closed 1 year ago

mathomp4 commented 1 year ago

Inspired by #46 (and before I forget) in https://github.com/GEOS-ESM/GEOSgcm_App/pull/377 @sanAkel updated the MERRA-2 location because:

/discover/nobackup/projects/gmao/share/gmao_ops/verification/MERRA-2

stopped in 2020. I see this same path in the CTM.

A similar change should happen here.

mmanyin commented 1 year ago

@mathomp4 - the CTM actually never runs in "replay" mode, so the env vars related to REPLAY are superfluous. I can take them out, unless you think that maintaining the site-specific settings is easier if all the setup scripts are kept in lock-step (i.e. including extraneous env vars).

sanAkel commented 1 year ago

@mathomp4 - the CTM actually never runs in "replay" mode, so the env vars related to REPLAY are superfluous. I can take them out, unless you think that maintaining the site-specific settings is easier if all the setup scripts are kept in lock-step (i.e. including extraneous env vars).

@mmanyin If you don't need something best to not have it!

mmanyin commented 1 year ago

@sanAkel this is true. I was pointing out that the task of maintaining a collection of setup scripts (for gcm, GMI, StratChem, GEOS-Chem, scm, CTM, etc) is less onerous if the common sections can be kept identical. But in this case it likely leads to confusion. I need to review ctm_setup for more than just this issue -- will revise it in the near future.

sanAkel commented 1 year ago

@sanAkel this is true. I was pointing out that the task of maintaining a collection of setup scripts (for gcm, GMI, StratChem, GEOS-Chem, scm, CTM, etc) is less onerous if the common sections can be kept identical. But in this case it likely leads to confusion. I need to review ctm_setup for more than just this issue -- will revise it in the near future.

Sounds good and would suggest a review of ALL common elements.

FWIW I know that every time something changes in 'gcm_setup', @mathomp4 repeats that in many other scripts- that's a terrible waste of our time.

We can do better!

mmanyin commented 1 year ago

The references related to running in "Replay Mode" have been removed from CTM, as of release v2.2.2 . Recommend that this issue be closed.