search

GEOS-ESM / GEOSgcm

GEOS Earth System Model GEOSgcm Fixture
Apache License 2.0
36 stars 13 forks source link

Integrate WMMA #724

Closed adarmenov closed 10 months ago

adarmenov commented 11 months ago

Integrate WMMA changes into main.

adarmenov commented 11 months ago

@sdrabenh - I've created PRs in GMAO_Shared, GEOSgcm_GridComp, GEOS_OceanGridComp and GEOSgcm_App. The WMMA (WAVEWATCH, UMWM, sea spray) changes in these fixtures are in branches named 'feature/adarmenov/integrate-wmma'.

adarmenov commented 11 months ago

The PRs are:

mathomp4 commented 11 months ago

The first GNU CI failure is due to using an Intel compiler flag with GNU. I'm going to try and fix this up.

I might also propose some changes to some of the CMake. What's there works, but it's not quite the style we currently use in GEOS CMake.

I assume @sanAkel is looking at the coupled run failure.

adarmenov commented 11 months ago

... I assume @sanAkel is looking at the coupled run failure.

The reason for the coupled run failure is that only datasea has the 'DW' export. If ocean depth is not an export that would be required in the foreseeable future by GCs other than WGCM, then IMO it will be easier if this variable is handled by WGCM. Thoughts @sanAkel?

mathomp4 commented 11 months ago

Okay. I have two new PRs in GEOSgcm_GridComp and WW3:

with the changes I needed for GNU builds. I'll try and retrigger the CI here to see if it gets further.

In my testing, these are zero-diff for an AMIP Intel run where waves aren't used.

mathomp4 commented 11 months ago

I'll try and retrigger the CI here to see if it gets further.

Sigh. I'm an idiot. The CI won't work until these are in the anton branches. Friday brain.