search

GEOS-ESM / GEOSgcm

GEOS Earth System Model GEOSgcm Fixture
Apache License 2.0
35 stars 13 forks source link

Uppercase ESMF_ROOT for Spack #768

Closed mathomp4 closed 5 months ago

mathomp4 commented 7 months ago

Closes #767

Per @climbfuji, we should use ESMF_ROOT instead of esmf_ROOT as that is more conventional.

This does not affect GEOS-with-Baselibs runs as we are not in this block.

Note, I've also uppercased the target to ESMF as that is what ESMF itself provides. Eventually we should change this to ESMF::ESMF but that will need to wait for ESMF 8.6.1

climbfuji commented 7 months ago

Thanks @mathomp4 ! Maybe we can wait merging this until the new spack-stack using the uppercase version is rolled out?

mathomp4 commented 7 months ago

@climbfuji If you can test it to make sure it works, that's great, but we can hold off as long as you'd like as it doesn't affect our Baselibs builds.

Once you need it let us know.

mathomp4 commented 7 months ago

I'll mark this draft to make sure we don't merge until wanted.

climbfuji commented 5 months ago

Uhh, didn't we revert this uppercase change because of all the cmake warnings? And raised it with the spack developers?

mathomp4 commented 5 months ago

Uhh, didn't we revert this uppercase change because of all the cmake warnings? And raised it with the spack developers?

@climbfuji This has been kept draft for now. We can close it if you like. I wasn't sure if you still wanted it or not so... Up to you!

climbfuji commented 5 months ago

I checked on my mac, and we indeed reverted to case-preserving packageName_ROOT. Let's close this. Sorry for the hassle!

mathomp4 commented 5 months ago

I checked on my mac, and we indeed reverted to case-preserving packageName_ROOT. Let's close this. Sorry for the hassle!

Eh. Wasn't exactly a hard PR to make :) Closing!