search

GEOS-ESM / GEOSgcm_App

Repo containing the scripts for running the GEOS Earth System Model GCM
Apache License 2.0
2 stars 1 forks source link

Do not link unnecessary files! #574

Closed sanAkel closed 7 months ago

sanAkel commented 7 months ago

This PR gets rid of unnecessary linking of files, which have this pattern: *CF0180x6C_TM1440xTM1080_CF0180x6C_DE0360xPE0180.bin

These files are not needed anymore and removing their links, DOES NOT impact coupled .and. uncoupled runs. With those links gone, the gcm_run.j generated scratch dir is really small (file count!).

Thanks to @atrayano for helping.

cc: @mathomp4, @sdrabenh

mathomp4 commented 7 months ago

@sanAkel I think @sshakoor1 took care of that line as well in #544, but can you take a look:

https://github.com/GEOS-ESM/GEOSgcm_App/pull/544/files#diff-2314fdf41455508fb50c68c9de6135f31f0fc99057eccbd6169e20c499566963

In that PR, he's moved the linkbcs code into its own script since we figured it was weird that gcm_run.j was creating a script on the fly when gcm_setup could do it just as well.

We took the time to sort of remove lots of lines we thought were archaic and unneeded.

sanAkel commented 7 months ago

@mathomp4 Not sure @sshakoor1 and co will mark their PR ready. If that is > 1 week, can we please move ahead with this one? @sdrabenh, will that work?

sshakoor1 commented 7 months ago

@sanAkel it will most likely be >1 week before my PR is ready for reasons out of my control. You all can move forward with this PR in the mean time.

mathomp4 commented 7 months ago

I think the CI is failing here because it's picking up the sanAkel-patch-1 branch in Ocean:

GEOS_OceanGridComp     | (b) sanAkel-patch-1

@sanAkel Do you mind if I rename this branch just so the CI will be happy?

sanAkel commented 7 months ago

Go ahead @mathomp4