GEOS-ESM / GEOSgcm_GridComp

Repository containing the physics and IAU code for the GEOS Earth System Model
Apache License 2.0
9 stars 7 forks source link

CICE6 cmake and namelist updates for post release v6.5.0 merge #925

Closed zhaobin74 closed 3 months ago

zhaobin74 commented 5 months ago

This PR updated CMake and ice_in (CICE6 config file) to be consistent with upstream merge of CICE6.

Zero-diff for AMIP and coupled CICE4.

Depends on https://github.com/GEOS-ESM/CICE/pull/6 and https://github.com/GEOS-ESM/Icepack/pull/5, and https://github.com/GEOS-ESM/GEOSgcm/pull/779

github-actions[bot] commented 5 months ago

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

sanAkel commented 4 months ago

@zhaobin74 It's better to separate PRs that change:

From maintenance point of view- for your future reference.

zhaobin74 commented 4 months ago

@zhaobin74 It's better to separate PRs that change:

  • icepack (e.g., cmake change).
  • code change (lhf).

From maintenance point of view- for your future reference.

Thanks for approving, @sanAkel. I will split them in future PRs.