search

GEOS-ESM / GEOSgcm_GridComp

Repository containing the physics and IAU code for the GEOS Earth System Model
Apache License 2.0
9 stars 7 forks source link

Bugfix/narnold1/turb budget fix #929

Closed narnold1 closed 1 month ago

narnold1 commented 1 month ago

This fixes an issue of double-counting in the Turbulence kinetic energy budget. The surface drag contribution, KESRF, was being included in the diffusive term, KEINT. This properly separates the two for the budget calculation.

github-actions[bot] commented 1 month ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

github-actions[bot] commented 1 month ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

narnold1 commented 1 month ago

@narnold1 , just verifying that you really want to add SRFDIS to this export and not subtract?

Yes, the bug is that the SRF contribution is already included in INTDIS and KEINT above. So here we need remove it from KEINT (by adding instead of subtracting). Similarly, no need to include the SRF contribution in KETRB, because it was already included along with 'INT' above.

This fix leaves the 'INTDIS' export untouched so as to remain 0-diff (it's used in PhysGridComp to compute dissipative heating, but not directly used in M21C HISTORY), but eventually we should fix INTDIS as well. I have code to do that for a future non-0-diff update to develop.