search

GEOS-ESM / GEOSldas_GridComp

Apache License 2.0
1 stars 0 forks source link

add landice gridcomp #18

Open weiyuan-jiang opened 6 months ago

weiyuan-jiang commented 6 months ago

This PR is corresponding to the GEOSldas PR to add GEOSlake_GridComp

gmao-rreichle commented 5 months ago

@weiyuan-jiang: I just came across the following assumption in pre-processing: the *.til file must have all of the land tiles at the beginning. This has worked so far, but it is not a safe assumption (as noted in my comment from 2020). You are probably already aware of it in the context of the present PR, but I'm mentioning it here just in case.

https://github.com/GEOS-ESM/GEOSldas_GridComp/blob/05bbcca97230ced6591d38e4b475c9db9915971f/GEOSldas_App/preprocess_ldas_routines.F90#L2125

    ! assume all land tiles are at the beginning
          ! UNSAFE ASSUMPTION! - reichle, 2 Aug 2020

          if (typ/=MAPL_Land .and. typ/=MAPL_Land_ExcludeFromDomain) then   ! exit if not land

             if (logit) then
                write (logunit,*) 'WARNING: Encountered first non-land tile in *.til file.'
                write (logunit,*) '         Stop reading *.til file under the assumption that'
                write (logunit,*) '           land tiles are first in *.til file.'
                write (logunit,*) '         This is NOT a safe assumption beyond Icarus-NLv[x] tile spaces!!'
             end if

             exit ! assuming land comes first in the til file

          end if
gmao-rreichle commented 5 months ago

@weiyuan-jiang: I just came across the following assumption in pre-processing...

PS: The exact same code appears again a couple of hundred lines later:

https://github.com/GEOS-ESM/GEOSldas_GridComp/blob/05bbcca97230ced6591d38e4b475c9db9915971f/GEOSldas_App/preprocess_ldas_routines.F90#L2378