search

GEOS-ESM / GFDL_atmos_cubed_sphere

The GFDL atmos_cubed_sphere dynamical core code
Other
0 stars 2 forks source link

Feature/tclune/#81 compute coords locally #83

Closed tclune closed 1 year ago

tclune commented 1 year ago

This PR introduces new algorithms for computing lat lon corners of cubed sphere. These new routines use far less memory, as no global domain arrays are involved. They are also arguably more accurate, and run faster not that the latter are significant concerns.

These have not been validated in GEOS, and the default behavior is to use the older coordinates for backward compatibility. This can be toggled by seting compute_coords_locally = .true. in the fv_core_nml namelist.

github-actions[bot] commented 1 year ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Non 0-diff, Needs Lead Approval, Skip Changelog

github-actions[bot] commented 1 year ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Non 0-diff, Needs Lead Approval, Skip Changelog

github-actions[bot] commented 1 year ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Non 0-diff, Needs Lead Approval, Skip Changelog

github-actions[bot] commented 1 year ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Non 0-diff, Needs Lead Approval, Skip Changelog

github-actions[bot] commented 1 year ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Needs Lead Approval, Skip Changelog

github-actions[bot] commented 1 year ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Needs Lead Approval, Skip Changelog

github-actions[bot] commented 1 year ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Needs Lead Approval, Skip Changelog

mathomp4 commented 1 year ago

I confirm that this along with https://github.com/GEOS-ESM/FVdycoreCubed_GridComp/pull/258 is zero-diff (when not activated, of course)

github-actions[bot] commented 1 year ago

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Needs Lead Approval, Skip Changelog