search

GEOS-ESM / GOCART

GOCART Aerosol model including process library and framework interfaces (MAPL, NUOPC, and CCPP)
Apache License 2.0
15 stars 14 forks source link

Update State Specs for *-expansion in Long Names #202

Closed mathomp4 closed 1 year ago

mathomp4 commented 1 year ago

@darianboggs recently added the ability in MAPL to expand * in long name with the ACG:

https://github.com/GEOS-ESM/MAPL/pull/1881

This feature will be in the next version of MAPL (2.34.0) which will be released "soon". As such, this is an issue reminder to update the state specs in files where star-expansion is done. At the moment I think it's only in CA:

https://github.com/GEOS-ESM/GOCART/blob/984fc494abfcd95ff3c2ced49dc0ab11176b8510/ESMF/GOCART2G_GridComp/CA2G_GridComp/CA2G_StateSpecs.rc#L75-L78

but others might use it in branches in development? The above lines should become:

 NAME         | UNITS        | DIMS  | VLOC  | UNGRIDDED                      | LONG NAME
#----------------------------------------------------------------------------------------
 *MASS        | kg kg-1      | xyz   | C     |                                | * Carbonaceous Aerosol Mass Mixing Ratio
 *CONC        | kg m-3       | xyz   | C     |                                | * Carbonaceous Aerosol Mass Concentration

as an example. Note you want to make sure you have the space so this:

* Carbonaceous ...

not:

*Carbonaceous ...

as the Python will do:

CA.bcCarbonaceous ...

for the latter.

mathomp4 commented 1 year ago

Note also as of https://github.com/GEOS-ESM/MAPL/pull/1899, the %d is also expanded. So if you update specs with the * you will get:

        float BCDP001(time, lat, lon) ;
                BCDP001:long_name = "CA.bc Carbonaceous Aerosol Dry Deposition (Bin 001)" ;

MAPL 2.34 should be released today.

mathomp4 commented 1 year ago

Wait. I just realized this isn't quite right. I need to work with @darianboggs.