search

GEOS-ESM / GOCART

GOCART Aerosol model including process library and framework interfaces (MAPL, NUOPC, and CCPP)
Apache License 2.0
15 stars 14 forks source link

Removed all *ExtData.rc from GOCART/ #269

Closed jrjoshi1 closed 3 months ago

jrjoshi1 commented 8 months ago

Regarding issue #267 Removed all the *ExtData.rc files from the GOCART/ directory (in develop), those from the parallel 'AChem' not changed.

github-actions[bot] commented 8 months ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

mathomp4 commented 8 months ago

@jrjoshi1 You have now encountered both the GMAO Label Enforcer and Changelog Enforcer.

For the first, you need to add a label of either "0 diff", "0 diff trivial", "0 diff structural", or "Non 0-diff". Most use the first or last. The middle two are for things like "added to readme" or "moved a file".

The second is the Changelog Enforcer which make sure you have added an entry to CHANGELOG.md. We follow Keep a Changelog format (ish), so you make entries under things like "Changed" or "Removed" etc. You can see in the file various examples.

jrjoshi1 commented 8 months ago

@mathomp4 Thank you. Will work on that. Perhaps delete this branch, work on new, and then issue PR with a label and a changelog entry.

mathomp4 commented 8 months ago

@mathomp4 Thank you. Will work on that. Perhaps delete this branch, work on new, and then issue PR with a label and a changelog entry.

@jrjoshi1 No need to do that. You can just edit the CHANGELOG on your branch and push (or even edit here on the web).

And then the label is just over on the right of this webpage:

Screenshot 2024-03-12 at 9 44 50 AM

github-actions[bot] commented 8 months ago

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: