search

GEOS-ESM / MAPL

MAPL is a foundation layer of the GEOS architecture, whose original purpose is to supplement the Earth System Modeling Framework (ESMF)
https://geos-esm.github.io/MAPL/
Apache License 2.0
27 stars 17 forks source link

Add a new unit test for file utilities #1692

Open tclune opened 2 years ago

tclune commented 2 years ago

This ticket is motivated by something that turned out to be a false alarm, but ...

The existing tests: https://github.com/GEOS-ESM/MAPL/blob/f3ddd913badac0c17a53e6cd63e9e6e28966cebc/shared/tests/test_FileSystemUtilities.pf#L8-L18 are ok, but ... we should also check for files that have extra "." in the name.

E.g., do we get the right extension and right basename for "A.B.C" as opposed to just "A.B"?
And the basename test does not include the case of a filename without any suffix. A test should be added for just "A".

Very easy to do, but I don't have a recent build of GEOS. Easier for me to assign to @darianboggs as just a small item that he can do incidentally with some other ticket.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days, it will be closed. You can add the "long term" tag to prevent the Stale bot from closing this issue.

mathomp4 commented 1 year ago

Not stale, just low priority until @darianboggs can get to it.

I'll long-term it.