read explicit "string" type of an attribute of a netcdf variable - Githubissues

GEOS-ESM / MAPL

MAPL is a foundation layer of the GEOS architecture, whose original purpose is to supplement the Earth System Modeling Framework (ESMF)

https://geos-esm.github.io/MAPL/

Apache License 2.0

27 stars 17 forks source link

read explicit "string" type of an attribute of a netcdf variable #3026

Closed weiyuan-jiang closed 3 weeks ago

weiyuan-jiang commented 3 weeks ago

Types of change(s)

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)
[ ] Refactor (no functional changes, no api changes)

Checklist

[] Tested this change with a run of GEOSgcm
[x ] Ran the Unit Tests (make tests)

Description

When a variable's attribute type is explicitly declared as 'string', it would be ignored by the formatter. This PR fixes that problem.

Related Issue

tclune commented 3 weeks ago

@weiyuan-jiang Please fix the conflicts in the CHANGELOG.

weiyuan-jiang commented 3 weeks ago

@tclune Why it is closed? Do you want me to create another hot fix PR ?

tclune commented 3 weeks ago

Closed? I did not close it.