Feature/fixes #3025 - Githubissues

GEOS-ESM / MAPL

MAPL is a foundation layer of the GEOS architecture, whose original purpose is to supplement the Earth System Modeling Framework (ESMF)

https://geos-esm.github.io/MAPL/

Apache License 2.0

27 stars 17 forks source link

Feature/fixes #3025 #3028

Closed bena-nasa closed 2 weeks ago

bena-nasa commented 2 weeks ago

Fixes #3025 Was too zealous in removing stuff that will be refactored. Restored it for now to restore 0-diff in GEOS

Types of change(s)

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)
[ ] Refactor (no functional changes, no api changes)

Checklist

[X] Tested this change with a run of GEOSgcm
[ ] Ran the Unit Tests (make tests)

Description

Related Issue

mathomp4 commented 2 weeks ago

Shouldn't this be a hotfix onto main?

@tclune No. The bug was only ever in develop. I was thinking it was time for a new release, but we lucked out!