search

GEOS-ESM / MAPL

MAPL is a foundation layer of the GEOS architecture, whose original purpose is to supplement the Earth System Modeling Framework (ESMF)
https://geos-esm.github.io/MAPL/
Apache License 2.0
27 stars 17 forks source link

Odd time print format from Cap #3034

Closed mathomp4 closed 1 week ago

mathomp4 commented 2 weeks ago

Per @briardew, he was wondering about these prints from Cap:

CAP: INFO: Read CAP restart properly, Current Date =   2019/08/08
CAP: INFO:                            Current Time =   03/00/00

Namely: Why is the time represented by slashes. My only guess is that it was that way long ago in MAPL and, well, we just never changed it.

The code would be simple to change:

https://github.com/GEOS-ESM/MAPL/blob/c7926cd3ce4c0bf66fd01f54b0c50ce2ec9900fa/gridcomps/Cap/MAPL_CapGridComp.F90#L1852-L1853

The question is: Should we? I appeal to @atrayano and @bena-nasa to know if they know of anyone or any scripts that depend on this format?

I'll even mention at @rtodling in case he knows of an ADAS script that depends on this output for any reason.

And, why not, I'll mention @tclune because everyone else has been. 😄

atrayano commented 2 weeks ago

I ready do not think anybody cares... Cannot imagine that we parse the time from this output. My vote is to change it.

briardew commented 2 weeks ago

If we want to go real crazy, we could also change the date to be 2019-08-08 to be more ISOy. Agree with Atanas that likely no one cares except me.

On Thu, Sep 19, 2024 at 8:48 AM Atanas Trayanov @.***> wrote:

I ready do not think anybody cares... Cannot imagine that we parse the time from this output. My vote is to change it.

— Reply to this email directly, view it on GitHub https://github.com/GEOS-ESM/MAPL/issues/3034#issuecomment-2360895308, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKXORYVNFYCVJUG2GOID4GTZXLBYFAVCNFSM6AAAAABOPZGWZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRQHA4TKMZQHA . You are receiving this because you were mentioned.Message ID: @.***>

mathomp4 commented 1 week ago

Just for @tclune benefit, I did communicate to @briardew that MAPL3 will be using ISO time format.

I suppose if we wanted, we could conver this logging output to ISO...