GEOS-ESM / MAPL

MAPL is a foundation layer of the GEOS architecture, whose original purpose is to supplement the Earth System Modeling Framework (ESMF)

https://geos-esm.github.io/MAPL/

Apache License 2.0

24 stars 18 forks source link

Get array size of a condensed rank-3 array pointer formed from ESMF_Field Fortran pointer #3045

Closed darianboggs closed 1 month ago

darianboggs commented 2 months ago

Types of change(s)

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)
[ ] Refactor (no functional changes, no api changes)

Checklist

[ ] Tested this change with a run of GEOSgcm
[x] Ran the Unit Tests (make tests)

Description

We need a rank-agnostic way to interface with ESMF_Field instances. (See #3021 for more details.) The resulting array pointer will have rank-3 with dimensions (h, v, u).

h: horizontal dimensions collapsed to rank-1
v: vertical dimension
u: ungridded dimensions collapsed to rank-1.

Related Issue

3021

darianboggs commented 2 months ago

Currently, the rank-3 pointer is in a separate public procedure pending feedback on the location.

darianboggs commented 1 month ago

I still need to fix the failing Exception test, and move the public interface for the fptr to FieldCondensedArray.F90 with the rank-3 return type.

darianboggs commented 1 month ago

Also, I am cleaning up comments and _HERE lines.

tclune commented 1 month ago

For the test that is failing with an expected exception, please post more details here. What error message do you actually get from the framework?

darianboggs commented 1 month ago

Here is the message for the failing exception test:


 Failure in <
 Test_FieldCondensedArray_private_suite.test_get_fptr_shape_wrong_order>
F   end: <Test_FieldCondensedArray_private_suite.test_get_fptr_shape_wrong_order
 >

Time:         0.034 seconds

Failure
 in:
Test_FieldCondensedArray_private_suite.test_get_fptr_shape_wrong_order
  Location:
[FieldCondensedArray_private.F90:37]
MAPL expects geom dims before ungridded.```