Fixes #3062 - mapl accessors for ESMF info object - Githubissues

GEOS-ESM / MAPL

MAPL is a foundation layer of the GEOS architecture, whose original purpose is to supplement the Earth System Modeling Framework (ESMF)

https://geos-esm.github.io/MAPL/

Apache License 2.0

27 stars 17 forks source link

Fixes #3062 - mapl accessors for ESMF info object #3063

Closed tclune closed 2 hours ago

tclune commented 22 hours ago

eventually needs more overloads for other types

Types of change(s)

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)
[ ] Refactor (no functional changes, no api changes)

Checklist

[ ] Tested this change with a run of GEOSgcm
[x] Ran the Unit Tests (make tests)

Description

Related Issue

tclune commented 4 hours ago

Looks good. Since it is failing on the other compilers, I didn't approve.

The CI tests will prevent merging, so you should not let the failing tests in-and-of-themselves be a reason for not approving. Granted, you'll still have to review again when those fixes come in, but best to be clear about role in each step of the process.