Feature/wdboggs/change extension action methods 3108

GEOS-ESM / MAPL

MAPL is a foundation layer of the GEOS architecture, whose original purpose is to supplement the Earth System Modeling Framework (ESMF)

https://geos-esm.github.io/MAPL/

Apache License 2.0

24 stars 18 forks source link

Feature/wdboggs/change extension action methods 3108 #3112

Closed darianboggs closed 1 month ago

darianboggs commented 1 month ago

Types of change(s)

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)
[ ] Refactor (no functional changes, no api changes)

Checklist

[ ] Tested this change with a run of GEOSgcm
[x] Ran the Unit Tests (make tests)

Description

Change run to update and invalidate method for ExtensionAction.

Related Issue

Closes issue #3108

darianboggs commented 1 month ago

Since I added invalidate method to ExtensionAction, all the types derived from it need an invalidate method also. Rather than add an no-op method to each of the extended types, I added a no-op invalidate method to the abstract type. Extended types can overload the method as needed. If we want the abstract type to have only deferred methods, we could create a "base" or "implementation" abstract type extended from ExtensionAction that the current extended types would extend instead. Open to suggestions.

darianboggs commented 1 month ago

ifort is compiling. gfortran is not.