Vertical regridding - step 2 - FixedLevels -> FixedLevels - Githubissues

GEOS-ESM / MAPL

MAPL is a foundation layer of the GEOS architecture, whose original purpose is to supplement the Earth System Modeling Framework (ESMF)

https://geos-esm.github.io/MAPL/

Apache License 2.0

24 stars 18 forks source link

Vertical regridding - step 2 - FixedLevels -> FixedLevels #3115

Closed pchakraborty closed 3 weeks ago

pchakraborty commented 4 weeks ago

Types of change(s)

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)
[ ] Refactor (no functional changes, no api changes)

Checklist

[ ] Tested this change with a run of GEOSgcm
[x] Ran the Unit Tests (make tests)

Description

Vertical regridding between FixedLevels and FixedLevels. Also

Overloaded formatted write for FixedLevelsVerticalGrid
Moved coupler phases to a separate file
Added write overload in VerticalRegridAction
Block in FieldSpec eliminated - Basic and FixedLevels vertical grids currently handled
Updated StateItemSpec interface for match_one to catch exceptions

Related Issue

pchakraborty commented 3 weeks ago

See inline comment - only one important structural issue caught my eye on this pass.

Next iteration I want to make sure I understand how/if this supports height vs pressure as coordinate and staggering.

Issues have been resolved