Make `get_fptr_shape` public and a bug fix - Githubissues

GEOS-ESM / MAPL

MAPL is a foundation layer of the GEOS architecture, whose original purpose is to supplement the Earth System Modeling Framework (ESMF)

https://geos-esm.github.io/MAPL/

Apache License 2.0

24 stars 18 forks source link

Make `get_fptr_shape` public and a bug fix #3118

Closed pchakraborty closed 3 weeks ago

pchakraborty commented 3 weeks ago

Types of change(s)

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)
[ ] Refactor (no functional changes, no api changes)

Checklist

[ ] Tested this change with a run of GEOSgcm
[ ] Ran the Unit Tests (make tests)

Description

Excluding negative values of gridToFieldMap
Making mapl3g_FieldCondensedArray::get_fptr_shape public

Related Issue

pchakraborty commented 3 weeks ago

I would still like to see a unit test that guards against this issue. This is the 2nd bug that has been found in this interface. First was that the gridToFieldMap was not even being allocated, and the unit tests only covered the lower level procedures. (@darianboggs)

Created issue #3127

tclune commented 3 weeks ago

I'm not sure what the use case for get_fptr_shape being public is, but I'm not opposed.

I think you are out of date. That was removed.