search

GEOUNED-org / GEOUNED

A tool to convert CAD to CSG & CSG to CAD for Monte Carlo transport codes
European Union Public License 1.2
56 stars 30 forks source link

Fixing issue 154 #158

Closed shimwell closed 4 months ago

shimwell commented 4 months ago

Fixing issue #154

First the PR adds a test to the CI which should fail as the bug is present

Then the 2nd commit fixes the bug and the CI including the new test should pass 🤞

shimwell commented 4 months ago

oh that is a nice find,

The CI failed in a new way

                if is_fuzzy and fuzzy[0]:
>                   Fuzzy(
                        fuzzy[1], "cylAxs", cyl1, cyl2, d, tol, tolerances, numeric_format
                    )
E                   TypeError: Fuzzy() missing 1 required positional argument: 'numeric_format'

I can fix this on this PR, but I think it shows we need to test more perturbations of all the input options

shimwell commented 4 months ago

this PR is ready for review if anyone has time