search

GEOUNED-org / GEOUNED

A tool to convert CAD to CSG & CSG to CAD for Monte Carlo transport codes
European Union Public License 1.2
45 stars 27 forks source link

openmc_py and openmc_xml lower case #166

Closed shimwell closed 1 month ago

shimwell commented 1 month ago

When specifying an outFormat most of the codes are in lower case appart from the best one 😉

currently we need to request openmc outputs with openMC_PY and openMC_XML which is a bit tricky to remember which letters are upper case and which are not and also inconsistent with the other codes.

This PR proposes that we change these to be lower case like the other codes

documentation has been updated

There is a nice check in the code so anyone using it will get a reasonable error message if trying the old upper case names

https://github.com/GEOUNED-org/GEOUNED/blob/6daf2e363bfa46c038c191f6a8581dfae07260b7/src/geouned/GEOUNED/write/write_files.py#L31-L35

shimwell commented 1 month ago

this one is ready for review whenever anyone has time