GEOUNED-org / GEOUNED

A tool to convert CAD to CSG & CSG to CAD for Monte Carlo transport codes
European Union Public License 1.2
56 stars 30 forks source link

Moving decompose solids into CadToCsg class #183

Closed shimwell closed 4 months ago

shimwell commented 4 months ago

Description

Just looking at the attributes used in decompose solid it save a bit of data passing around if we move the decompose solid into the CadToCsg class. Save a few lines of code

The users will still not see this function as it has been made private, so it also won't appear in the docs. But I think this is the first step towards letting users perform the decomposition as a separate step and exposing this option to users

Checklist

shimwell commented 4 months ago

this one is ready for review if anyone has time

shimwell commented 4 months ago

Thanks for the additional changes, I've implemented as suggested