GEOUNED-org / GEOUNED

A tool to convert CAD to CSG & CSG to CAD for Monte Carlo transport codes

European Union Public License 1.2

45 stars 27 forks source link

Moving get universe out of start method #188

Closed shimwell closed 1 month ago

shimwell commented 1 month ago

Description

Simple PR that moves some more logic from the start() method, this time we are moving the bounding box calculation outside. While doing this I noticed there was a hard coded parameter of 10 used for enlarging the bounding box. So I've added that as an argument. One benefit of #184 would be ease of exposing these options to the user.

Fixes issue

Please link to any issues that this PR fixes

Checklist

[x] I'm making a PR from a feature branch on my fork into GEOUNED-org/GEOUNED/dev branch
[x] I have followed PEP8 style guide for Python or run a formatter such as black or ruff format on my code

shimwell commented 1 month ago

this one is ready for review if anyone has time