GEOUNED-org / GEOUNED

A tool to convert CAD to CSG & CSG to CAD for Monte Carlo transport codes

European Union Public License 1.2

45 stars 27 forks source link

Moving decompose logic out of CadToCsg.start to its own method #189

Open shimwell opened 1 month ago

shimwell commented 1 month ago

Description

This PR moves some decomposition logic out of the start method

Fixes issue

partly helps with #184 and #114

Please link to any issues that this PR fixes

Checklist

[x] I'm making a PR from a feature branch on my fork into GEOUNED-org/GEOUNED/dev branch
[x] I have followed PEP8 style guide for Python or run a formatter such as black or ruff format on my code

shimwell commented 1 month ago

Thanks for letting me know, I shall move the process cones back to the end of the order.

Also looks like we need some more tests then as this is passing

shimwell commented 1 month ago

I've now moved the process cones section back to the original location.

Keen to fix the surfaces so that the ordering of steps does not change the outcome, something for the future

shimwell commented 1 month ago

thanks for the detailed review, I'm going to work on the documentation versioning and come back to this later as it looks like it needs much more thought than I originally estimated. IT would be great if the code allowed more flexibility with the order that things are run so perhaps we even need a few PRs to work on the information flow before finishing this one