GEOUNED-org / GEOUNED

A tool to convert CAD to CSG & CSG to CAD for Monte Carlo transport codes
European Union Public License 1.2
45 stars 27 forks source link

Simplify error #211

Closed KBGrammer closed 3 weeks ago

KBGrammer commented 3 weeks ago

Description

The get_box function in functions.py took the parameters comp and options, and used only options.enlargeBox. The previous fix in core.py for the call to this function passed self.options.enlargeBox. cut_box has been changed to take the parameters comp and enlargeBox.

An additional call to cut_box is in cell_definition.py that was missing the second parameter. The call here has been replaced with changed from only "m" to "m" and options.enlargeBox.

The result of the first issue is that simplify = "full" fails.

Fixes issue

Previous fix to #203 was not sufficient. This should be.

Checklist

shimwell commented 3 weeks ago

These three line changes look good to me. Thanks for another PR @KBGrammer LGTM

KBGrammer commented 3 weeks ago

I think this is ready to merge and should not require another attempt (famous last words).