GEOUNED-org / GEOUNED

A tool to convert CAD to CSG & CSG to CAD for Monte Carlo transport codes

European Union Public License 1.2

45 stars 27 forks source link

change default compSolids behaviour #246

Closed alexvalentine94 closed 1 day ago

alexvalentine94 commented 3 days ago

Description

The default behaviour for compSolids setting was set to True. This leads to solids in a single component being merged in the MCNP model cell definitions. The default should be false to respect the original structure tree.

Fixes issue

Checklist

[x] I'm making a PR from a feature branch on my fork into GEOUNED-org/GEOUNED/dev branch
[x] I have followed PEP8 style guide for Python or run a formatter such as black or ruff format on my code
[x] I have made corresponding changes to the documentation
[] I have added tests that prove my fix is effective or that my feature works

shimwell commented 2 days ago

looks like the code is attempting to append to a bool somewhere and this is causing the tests to fail

this does not look like it is introduced by the PR but rather a part of the code that was not previously being executed in the CI.

looks like the error is on geouned/GEOUNED/void/void_box_class.py line 351 in get_void_complementary which calls complementary.append(compSeq)

I guess complementary is the bool and is not appendable

psauvan commented 1 day ago

I have fixed the problem with the boolean value, and updated dev branch (#247). I rerun the tests but they still fail, it seems the tests are using the original source.

alexvalentine94 commented 1 day ago

I have merged your fix Patrick, thanks for pointing to this. Tests passing now :)