Closed psauvan closed 4 months ago
I think the load step file does not make use of information from the settings class or vice versa so perhaps the order does not matter?
the skip solids is not longer part of the settings class it is passed directly to the load_step method
def load_step_file(
self,
filename: typing.Union[str, typing.Sequence[str]],
skip_solids: typing.Sequence[int] = [],
):
Yes it does! the compSolids parameter of the Settings class is used in load_step_file method.
Load_step_file method was called before Settings class was updated.
If you are a first-time contributor to GEOUNED, please read our contributing guidelines: https://github.com/GEOUNED-org/GEOUNED/blob/main/CONTRIBUTING.md
Description
Please include a summary of the changes and motivation for the changes
Fixes issue
Please link to any issues that this PR fixes
Checklist