GER-Space / Kerbal-Konstructs

KSP Mod: Kerbal Konstrucs
https://forum.kerbalspaceprogram.com/index.php?/topic/151818-145-131-122-kerbal-konstructs-1452-12082018/&
27 stars 27 forks source link

VisibilityRange in configuration files ignored #130

Closed meltingSnowdrift closed 5 years ago

meltingSnowdrift commented 5 years ago

The "VisibilityRange" value in instance list cfg files appears to have no effect. Regardless of these values, models load and become unloaded at approximately 40km from the active vessel.

This problem was discovered when I tried to increase model loading ranges to create compatibility with Physics Range Extender by making Kerbal Konstructs models load at longer ranges than vessels to prevent vessels from falling to the ground before the KK models they rest on become loaded.

GER-Space commented 5 years ago

KK should now automatically adjust the loading range to the Physics Range (+ some extra KM)

I use this as a reference. + 1.5* the localgrouprange which is currently 25KM. PhysicsGlobals.Instance.VesselRangesDefault.flying.load

I don't know which parameter you change, maybe I poll the wrong one.

GER-Space commented 5 years ago

On a sencond thought, querrying the flying distance might not the best choice, as most objects on structures are on the landed state.

meltingSnowdrift commented 5 years ago

KK should now automatically adjust the loading range to the Physics Range (+ some extra KM)

At least in the presence of Physics Range Extender, this does not occur correctly. Regardless of settings in Physics Range Extender, KK loading distance seems to be around 40km. Also, what is meant by "flying distance"?

In addition to specifically resolving this issue, can you please make loading distances overridable by the user, preferably in the KK instance editor, so that we can manually work around these kinds of problems regardless of the particular case?

GER-Space commented 5 years ago

after looking into the https://github.com/jrodrigv/PhysicsRangeExtender code...

they never set the ranges globally and only use set it for the vessels directly. I have a patch for KK that will adjust the loading range for Buildings accordingly.

GER-Space commented 5 years ago

new Release is out with the bugfix for it:

https://github.com/GER-Space/Kerbal-Konstructs/releases/tag/1.4.5.47