GER-Space / Kerbal-Konstructs

KSP Mod: Kerbal Konstrucs
https://forum.kerbalspaceprogram.com/index.php?/topic/151818-145-131-122-kerbal-konstructs-1452-12082018/&
27 stars 26 forks source link

Custom Barn Kit Compatibility #159

Open Decus91 opened 4 years ago

Decus91 commented 4 years ago

When playing on patch 1.8.1, with KK version 1.8.1.15 or 1.8.1.14, with the KK dependency CustomPreLaunchChecks, the CustomBarnKit configs don't appear to be applying to the Research and Development Centre, though oddly enough they do apply to all the other facilities. I've had a look through the source code but can't find anything that should overwrite a CustomBarnKit config in general and most specifically for the Research and Development Centre, but when I play the game without KK and CPLC the configs do work, so it would appear to be a problem with KK. Any idea what might be causing this?

Decus91 commented 4 years ago

It appears that "public void LateUpdate()" in KerbalKonstructs.cs, Line 779 (for 1.8.1.14 which I'm working from) and the associated "CareerState.FixKSCFacilities" is not needed for any of the facilities other than the R&D centre, given that the R&D centre is an exception among all of the KSC facilities both for the above fix and also for recognising the Custom Barn Kit config, well, it may not be a coincidence... or it might be, just throwing this out there in case it helps anyone find the problem, as I've not been having much luck myself.

Decus91 commented 4 years ago

Having continued my work to find the issue, it appears that the initial facility referenced within LaunchSiteManager.cs Line 101 ("Where(x => x.name == "ResearchAndDevelopment").First().gameObject;") and in three other locations in the source code doesn't work with Custom Barn Kit, why this is I'm not sure, but in changing"ResearchAndDevelopment" to "FlagPole" in all four instances I have solved the issue. That said, I haven't assessed the full ramifications of this change so hopefully it hasn't broken anything. I'll leave this Issue open until you have read it so you can provide comment on this if you wish. If you know of no issues associated with this then I recommend it as a change to your mod (I can resubmit this as a Pull Request if you wish?).