search

GERARDJM018 / pe

0 stars 0 forks source link

Different from the suggested UML diagram notation. #10

Open GERARDJM018 opened 7 months ago

GERARDJM018 commented 7 months ago

Screenshot:

image.png

I find it the UML diagram here use different notation or style than what suggested in the module. Also, if this is allowed, I think it is better to use one style/notation for the DG to improves consistency.

soc-pe-bot commented 7 months ago

Team's Response

The team feels that the UML diagram is valid as it shouldn't affect readability and Style for all class diagrams is consistent through DG.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I think the diagram uses a non-standard notation (not recommended). I refer to the Tutorial 10 activity

Screenshot from T10-DG-Extracts-Answers.pdf (can be downloaded via canvas):

image.png

The notation here is similar to what you used and it is considered non-standard. Although it might be a valid notation, for this module CS2103, I think it's better to refrain from using other notation.

Also, what I mean by consistent is there are multiple notations used in your DG.

Screenshot from DG:

image.png

In this screenshot, it uses the normal notation which is different from the notation I pointed out in the issue.