GESS-research-group / pyshbundle

Convert SH bundle matlab codes to python
https://mn5hk.github.io/pyshbundle/
Other
8 stars 5 forks source link

pip compatibility #89

Closed mn5hk closed 4 months ago

mn5hk commented 10 months ago
mn5hk commented 8 months ago

Dear @abhimhamane,

I have currently created a new pypi release v0.1.1 that seems to be working: https://pypi.org/manage/project/pyshbundle/release/0.1.1/

As you have been more involved in the development of the notebooks, if possible, I request you to update the notebooks by calling the pypi module.

In addition, couple other tasks may be necessary:

Lastly, please note that the development for the pypi module is currently being undertaken in a dedicated branch: 89-pip-compatibility

Couple links that may be useful:

Maybe we have a meeting sometime later to wrap up a release version.

Best, AS

abhimhamane commented 8 months ago

Screenshot from 2024-01-13 13-29-40 The error occuring in timeseries and visualization notebooks. The error being 'module' object is not callable. From some of the online discussion forums it seems that, there is a conflict when the file and function has the same name. Here's a snippet from - https://discuss.streamlit.io/t/error-when-deploying-app-with-stream-select-menu/34711/5 Screenshot from 2024-01-13 16-10-41

I've tried using aliases to call functions but it does not work. One solution is to reorganize the functions as per their utility

  1. ioutils - reading data files
  2. graceshutils - SH processing of grace
  3. hydrograce - tws, basin avg and other hydrological application of grace data
  4. vizutils - visualization
abhimhamane commented 8 months ago

Reorganization is a bit more time-consuming. An easy fix for the initial release is to use a slightly different function name.

abhimhamane commented 8 months ago

Error with uploading to PyPi using Twine Screenshot from 2024-01-13 19-12-07

Also error related to sub-processor module while installing the module from tar.gz on windows. It needs to be looked into.

mn5hk commented 8 months ago

Hi @abhimhamane , I have updated the latest version to v0.1.2. I had uploaded v0.1.1 to pypi, but maybe I did not push the version to github; and hence, the error in version numbering.

Further, I have reinstalled pypi in my computer to the latest version and it was successful.

Could you try to check if the update works without errors in your PC? And also test it with our notebooks?

Thanks a lot, AS

mn5hk commented 8 months ago

Also, @abhimhamane , I noticed that you do not have the API token setup in your computer.

In this instance, the error is because pypi no longer allows changes to repos with username/password. Instead, you need to setup an API token on your computer. Let me know in case you face further issues regarding the API token.