GEUS-Glaciology-and-Climate / pypromice

Process AWS data from L0 (raw logger) through Lx (end user)
https://pypromice.readthedocs.io
GNU General Public License v2.0
14 stars 4 forks source link

Process testing triggered on PR #102

Closed PennyHow closed 1 year ago

PennyHow commented 1 year ago

.github/process_test.yml performs pypromice processing tests on real AWS data from PROMICE and GC-Net stations. This is triggered on pull requests to the main branch of pypromice as a Github Action, and can also be manually triggered. Similar to.github/unit_test.yml #101, a pull request can not be accepted until this workflow successfully passes. In addition, output files are posted as a Github Action artifact after each run here, so they can be viewed and checked.

A few notes:

patrickjwright commented 1 year ago

I agree that adding getL0tx and getBUFR will be important, but maybe not mandatory now, just to get this running and out the door. I left a few comments, but seems good to merge whenever you are happy.

patrickjwright commented 1 year ago

One other question. When exactly is this triggered? When you go to create a PR? Or when you try to merge the PR? And will both the unit test and the process test be triggered to run consecutively?

PennyHow commented 1 year ago

It should trigger when a PR is created, and it will block a PR from being merged if the tests fail. The unit and process test are triggered simultaneously.

At least, this is what I think should happen. It's hard to know if this is how it will work until it is merged with the main branch, but from reading around and testing on other branches, it should do! (fingers crossed!)

PennyHow commented 1 year ago

Now the two workflows are merged, I will test it with a branch that purposefully doesn't work. I'll open a PR, and the tests should fail and block a user from merging the PR.