search

GEUS-Glaciology-and-Climate / pypromice

Process AWS data from L0 (raw logger) through Lx (end user)
https://pypromice.readthedocs.io
GNU General Public License v2.0
12 stars 4 forks source link

Second test of unit and process testing (DO NOT MERGE) #105

Closed PennyHow closed 1 year ago

PennyHow commented 1 year ago

This is another trial of the unit and process tests (after https://github.com/GEUS-Glaciology-and-Climate/pypromice/pull/104).

This is an incomplete restructuring of the pypromice package that should fail with the unit and process tests. This is a test to see if the tests triggered by Github Actions fail and block the PR.

Please do not merge this

PennyHow commented 1 year ago

@patrickjwright, it works! Can you see the failed checks in this PR? So the process test failed after 3 minutes. The unit test first tried and failed on one Python environment. When one failed, it cancelled the unit testing on the other environments. I didn't realise it cancelled the others if one fails, but I don't think it is much of a problem.

Unfortunately, it does not directly block a PR from being merged, but I will have a read to see if there is a way we can do this.

PennyHow commented 1 year ago

Apparently we can block merging PRs with failed checks using the repo branch protection rules.

I've now added this to our main branch protection and see if it works.

patrickjwright commented 1 year ago

@PennyHow great! Yes I can see the test results as well.