search

GEUS-Glaciology-and-Climate / pypromice

Process AWS data from L0 (raw logger) through Lx (end user)
https://pypromice.readthedocs.io
GNU General Public License v2.0
12 stars 4 forks source link

Get module changed to fetch latest DOI using pyDataverse #112

Closed PennyHow closed 1 year ago

PennyHow commented 1 year ago

pypromice.get now retrieves the latest data file DOIs from the GEUS Dataverse using the Dataverse API pyDataverse, instead of using the DOI look-up table src/pypromice/data_urls.csv.

This requires pyDataverse as an additional dependency to pypromice. But I don't foresee too many installation issues. I also found a way to query the GEUS Dataverse without needing an API token (phew!)

The src/pypromice/data_urls.csv table and the Github Action .github/workflows/url_update.yml can therefore be retired.

patrickjwright commented 1 year ago

This looks good based on my brief review, and not having my hands too deep in this one! Thanks @PennyHow !

PennyHow commented 1 year ago

Thanks @patrickjwright. I'll go with this for now and if there are some good ideas for future development then we can implement it later.