search

GEUS-Glaciology-and-Climate / pypromice

Process AWS data from L0 (raw logger) through Lx (end user)
https://pypromice.readthedocs.io
GNU General Public License v2.0
12 stars 4 forks source link

[JOSS review] Documentation update #117

Closed jroettenbacher closed 1 year ago

jroettenbacher commented 1 year ago

Dear pypromice Team, I'm currently working on the review of your package. It's really great to see how easy it is to get your hands on data with this package! Great work! I went through your documentation and tried the code examples in a local copy of the repository.

Some of the cells did not compute because of import errors which I figured is due to a change in package structure which hasn't found its way into the documentation yet. This is nothing major and can be easily fixed.

Since it is so easy to fix, I add a pull request to this issue which would fix the problem. I do not expect you to merge my pull request. This is just to show you the exact changes needed.

Best Johannes

PennyHow commented 1 year ago

Thanks very much. Ah yes, some of the documentation has not been updated since we did some restructuring. Thanks for the PR, we are happy to merge this and I will also check the rest of the documentation if there is anything else that needs updating.

PennyHow commented 1 year ago

Documentation updated as part of #119. If you are happy with this then feel free to close this issue @jroettenbacher