search

GEUS-Glaciology-and-Climate / pypromice

Process AWS data from L0 (raw logger) through Lx (end user)
https://pypromice.readthedocs.io
GNU General Public License v2.0
12 stars 4 forks source link

Document pressure transducer fluid density #122

Closed PennyHow closed 1 year ago

PennyHow commented 1 year ago

Include reference to pressure transducer fluid density in function documentation.

https://github.com/GEUS-Glaciology-and-Climate/pypromice/blob/c5613a942d7e79089865f4f5837313bf6abe3461/src/pypromice/process/L0toL1.py#L234-L237

There is also a note here regarding tracking uncertainty. @mankoff, can you elaborate on this?

mankoff commented 1 year ago

I don't recall specifics of that note. However, it seems likely pt_antifreeze is unlikely to be exactly 50 in the case when it is not 100 %.

I suggest removing that note for now. Uncertainty propagation through this entire algorithm is a bigger issue.

PennyHow commented 1 year ago

Maybe I will just change the focus of this issue to the uncertainty propagation then, and move it to a new issue. Thanks @mankoff