GEUS-Glaciology-and-Climate / pypromice

Process AWS data from L0 (raw logger) through Lx (end user)
https://pypromice.readthedocs.io
GNU General Public License v2.0
12 stars 4 forks source link

Roof_GEUS, Roof_PROMICE, UWN have negative longitude #157

Closed patrickjwright closed 10 months ago

patrickjwright commented 11 months ago

As read from https://thredds.geus.dk/thredds/fileServer/metadata/AWS_latest_locations.csv, Roof_GEUS, Roof_PROMICE and UWN have negative longitude. These should be positive.

This file is written to by the WMO BUFR code... not sure why this would be negative. Negative should be degrees west, whereas positive is degrees east.

BaptisteVandecrux commented 10 months ago

This is done for all stations: https://github.com/GEUS-Glaciology-and-Climate/pypromice/blob/3424f2c6f81619bc04446a565fdc1666eaa16bc1/src/pypromice/process/aws.py#L119-L122

BaptisteVandecrux commented 10 months ago

fixed in the static metadata file: https://geusgitlab.geus.dk/glaciology-and-climate/promice/aws-l3/-/blob/main/AWS_metadata.csv

and in the L3 processing: https://github.com/GEUS-Glaciology-and-Climate/pypromice/tree/adding-metadata-as-attributes

BaptisteVandecrux commented 10 months ago

Fixed with #172