GEUS-Glaciology-and-Climate / pypromice

Process AWS data from L0 (raw logger) through Lx (end user)
https://pypromice.readthedocs.io
GNU General Public License v2.0
12 stars 4 forks source link

fix #209: wrong decoding of latitude and longitude when only decimal minutes are saved #211

Closed BaptisteVandecrux closed 7 months ago

BaptisteVandecrux commented 7 months ago

The original idea was that these decimal minutes should be added to the know degree of latitude/longitude of the station. The problem was that the "expected" latitude/longitude was not truncated of its digits, before it was added/appended to the minutes saved by the station.

So the main fix is the addition of a np.floor

I also noticed that right now the expected longitude in the config files are all (?) positive (degrees west). I added some np.sign and np.abs in the unlikely case of someone adding a new logger file where GPS is saved as mm.mmmm but enters a negative longitude in the config file.

should fix https://github.com/GEUS-Glaciology-and-Climate/PROMICE-AWS-data-issues/issues/90 and https://github.com/GEUS-Glaciology-and-Climate/pypromice/issues/209