GEUS-Glaciology-and-Climate / pypromice

Process AWS data from L0 (raw logger) through Lx (end user)
https://pypromice.readthedocs.io
GNU General Public License v2.0
14 stars 4 forks source link

Why is freezing limited to > -100? #22

Closed mankoff closed 1 year ago

mankoff commented 3 years ago

https://github.com/GEUS-PROMICE/PROMICE-AWS-processing/blob/a1508a6b06dc1ce749b0fa95c43a7879cb0993f1/IDL/AWSdataprocessing_v3.pro#L419

Should the > -100 be moved to a QA flag?

Dirk-van-As commented 3 years ago

Presumably it's there to eliminate the -999s and not identify those temperatures as "freezing". -100 should not be a flag.

PennyHow commented 1 year ago

This is how relative humidity correction currently looks:

https://github.com/GEUS-Glaciology-and-Climate/pypromice/blob/2331c02e1e121648c06dd054d370f0b99a6a8f6d/src/pypromice/L1toL2.py#L289-L293

According to @Dirk-van-As' advice, we will leave this as it is and not move it to a QA flag.